Skip to content

feat: refresh the Online users list on each heartbeat - #604

Merged
josephfusco merged 1 commit into
mainfrom
feat/users-list-live
Sep 27, 2026
Merged

josephfusco merged 1 commit into
mainfrom
feat/users-list-live

Conversation

@josephfusco

Copy link
Copy Markdown
Collaborator

Fixes #562

Rows come from core's list table with the page's query swapped into the heartbeat request, which is the part most likely to be wrong; the network view is only unit tested, and "N items" and the page links don't refresh.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the heartbeat handler, client swap and tests.

@github-actions

Copy link
Copy Markdown
Contributor

πŸ› WordPress Playgrounds

Built from 2e693b1

25 users 100 users
Single site Launch single site, 25 users Launch single site, 100 users
Multisite Launch multisite, 25 users Launch multisite, 100 users

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
βœ… Project coverage is 95.28%. Comparing base (4218200) to head (2e693b1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #604   +/-   ##
=========================================
  Coverage     95.28%   95.28%           
  Complexity      191      191           
=========================================
  Files            24       24           
  Lines          3054     3077   +23     
=========================================
+ Hits           2910     2932   +22     
- Misses          144      145    +1     
Flag Coverage Ξ”
multisite 95.28% <95.65%> (+<0.01%) ⬆️
phpunit 70.03% <91.30%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josephfusco
josephfusco marked this pull request as ready for review September 27, 2026 15:51
@josephfusco
josephfusco merged commit 01b8a70 into main Sep 27, 2026
21 checks passed
@josephfusco
josephfusco deleted the feat/users-list-live branch September 27, 2026 15:51
@github-actions

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@josephfusco josephfusco added [Area] Admin UI Issues for the admin UI integrations [Area] Heartbeat πŸ’“ Issues for the heartbeat subsystem labels Sep 27, 2026
@josephfusco josephfusco added this to the 0.10.0 milestone Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Admin UI Issues for the admin UI integrations [Area] Heartbeat πŸ’“ Issues for the heartbeat subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The online users list stops updating after page load

1 participant