Skip to content

fix: join the post room for what the Site Editor has open - #638

Merged
josephfusco merged 3 commits into
mainfrom
fix/site-editor-presence
Sep 27, 2026
Merged

josephfusco merged 3 commits into
mainfrom
fix/site-editor-presence

Conversation

@josephfusco

Copy link
Copy Markdown
Collaborator

Fixes #613

Switching entities inside the Site Editor leaves the previous room's row until it expires, so for up to the TTL someone shows in both places; templates still on the theme's file have no post ID and join no room until saved.

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Assisting with the Site Editor room and its tests.

@github-actions

Copy link
Copy Markdown
Contributor

πŸ› WordPress Playgrounds

Built from 90ad55e

25 users 100 users
Single site Launch single site, 25 users Launch single site, 100 users
Multisite Launch multisite, 25 users Launch multisite, 100 users

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 95.31%. Comparing base (c8ed2e5) to head (90ad55e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #638   +/-   ##
=========================================
  Coverage     95.31%   95.31%           
  Complexity      190      190           
=========================================
  Files            24       24           
  Lines          3265     3266    +1     
=========================================
+ Hits           3112     3113    +1     
  Misses          153      153           
Flag Coverage Ξ”
multisite 95.31% <100.00%> (+<0.01%) ⬆️
phpunit 70.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@josephfusco
josephfusco marked this pull request as ready for review September 27, 2026 21:38
@github-actions

Copy link
Copy Markdown
Contributor

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props joefusco.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@josephfusco
josephfusco merged commit aaf265d into main Sep 27, 2026
23 checks passed
@josephfusco
josephfusco deleted the fix/site-editor-presence branch September 27, 2026 21:38
@josephfusco josephfusco added this to the 0.11.0 milestone Sep 27, 2026
@josephfusco josephfusco added the [Area] Heartbeat πŸ’“ Issues for the heartbeat subsystem label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Heartbeat πŸ’“ Issues for the heartbeat subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site Editor templates, parts, navigation and patterns get no presence

1 participant