Repository navigation
Reapply "[wrangler] Add base path config to wrangler (#15754)" (#15915) - #15998
Merged
Merged
Conversation
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
@cloudflare/containers-shared
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/runtime-types
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. PR #15998 adds
|
dario-piotrowicz
marked this pull request as ready for review
October 1, 2026 21:46
workers-devprod
requested review from
a team and
petebacondarwin
and removed request for
a team
October 1, 2026 21:47
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Member
Author
|
I'm not sure whether deal with the above comments from Devin and Bonk in this PR or as a followup, since this PR is specifically reapplying the change made in #15754 I feel that it might be cleaner to merge this PR and deal with these comments later? |
edmundhung
approved these changes
Oct 5, 2026
workers-devprod
approved these changes
Oct 5, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 087ea32, effectively reapplying the changes in #15754. Those changes failed because of backend issues that now should be resolved (the e2es here will tell if they actually are 🤞)
A picture of a cute animal (not mandatory, but encouraged)