Skip to content

Reapply "[wrangler] Add base path config to wrangler (#15754)" (#15915) - #15998

Merged
dario-piotrowicz merged 1 commit into
mainfrom
dario/reapply-15754
Oct 5, 2026
Merged

dario-piotrowicz merged 1 commit into
mainfrom
dario/reapply-15754

Conversation

@dario-piotrowicz

Copy link
Copy Markdown
Member

This reverts commit 087ea32, effectively reapplying the changes in #15754. Those changes failed because of backend issues that now should be resolved (the e2es here will tell if they actually are 🤞)


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: already done (?)

A picture of a cute animal (not mandatory, but encouraged)

@dario-piotrowicz dario-piotrowicz added ci:e2e Run wrangler + vite-plugin E2E tests on a pull request ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials labels Oct 1, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Oct 1, 2026
Comment thread packages/config/src/schema.ts
@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15998

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15998

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15998

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15998

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15998

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15998

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15998

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15998

miniflare

npm i https://pkg.pr.new/miniflare@15998

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15998

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15998

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@15998

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15998

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15998

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15998

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15998

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15998

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15998

wrangler

npm i https://pkg.pr.new/wrangler@15998

commit: 03b08c6

@ask-bonk

ask-bonk Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

PR #15998 adds assets.base_path support across Wrangler, Miniflare, deployment, preview, and config conversion.

  1. P2 packages/config/src/schema.ts:22: The Wrangler-to-Cloudflare-config codemod silently drops legacy assets.base_path. Posted an inline suggestion.

github run

@dario-piotrowicz
dario-piotrowicz marked this pull request as ready for review October 1, 2026 21:46
@workers-devprod
workers-devprod requested review from a team and petebacondarwin and removed request for a team October 1, 2026 21:47
@workers-devprod

workers-devprod commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread packages/deploy-helpers/src/deploy/helpers/validate-routes.ts
Comment thread packages/deploy-helpers/src/deploy/helpers/validate-worker-props.ts
@dario-piotrowicz

Copy link
Copy Markdown
Member Author

I'm not sure whether deal with the above comments from Devin and Bonk in this PR or as a followup, since this PR is specifically reapplying the change made in #15754 I feel that it might be cleaner to merge this PR and deal with these comments later?

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@dario-piotrowicz
dario-piotrowicz merged commit b75421f into main Oct 5, 2026
105 of 138 checks passed
@dario-piotrowicz
dario-piotrowicz deleted the dario/reapply-15754 branch October 5, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request ci:run-remote-tests Run remote/E2E tests that require Cloudflare API credentials

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants