Skip to content

Remove secret/config duplication in cli/compose - #671

Merged
thaJeztah merged 3 commits into
docker:masterfrom
dnephin:remove-secret-config-duplication
Nov 15, 2017
Merged

thaJeztah merged 3 commits into
docker:masterfrom
dnephin:remove-secret-config-duplication

Conversation

@dnephin

@dnephin dnephin commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Nov 6, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #671 into master will increase coverage by 0.15%.
The diff coverage is 58.69%.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   50.49%   50.64%   +0.15%     
==========================================
  Files         216      216              
  Lines       17723    17727       +4     
==========================================
+ Hits         8949     8978      +29     
+ Misses       8325     8296      -29     
- Partials      449      453       +4

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Signed-off-by: Daniel Nephin <dnephin@docker.com>
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin
dnephin force-pushed the remove-secret-config-duplication branch 2 times, most recently from 3de9699 to f1cc679 Compare November 10, 2017 21:28
Signed-off-by: Daniel Nephin <dnephin@docker.com>
@dnephin
dnephin requested a review from thaJeztah November 14, 2017 23:56

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice 👍

@thaJeztah
thaJeztah merged commit 801ddee into docker:master Nov 15, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.12.0 milestone Nov 15, 2017
@dnephin
dnephin deleted the remove-secret-config-duplication branch November 15, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants