Repository navigation
Remove deprecated "daemon" subcommand - #689
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 50.49% 50.57% +0.07%
==========================================
Files 216 215 -1
Lines 17723 17678 -45
==========================================
- Hits 8950 8941 -9
+ Misses 8324 8290 -34
+ Partials 449 447 -2 |
dnephin
approved these changes
Nov 13, 2017
dnephin
left a comment
dnephin
left a comment
Contributor
There was a problem hiding this comment.
-tags daemon can also be removed from scripts/test/unit
Member
Author
|
Ah, yes, I started looking for that one; let me do that in this PR as well 👍 |
mdlinville
approved these changes
Nov 13, 2017
The `docker daemon` subcommand was only present for backward compatibility, but deprecated in v1.13, and scheduled for removal in v17.12 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove-daemon-subcommand
branch
from
November 13, 2017 18:01
4642fdf to
c6a3199
Compare
Member
Author
|
Updated: removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
docker daemonsubcommand was only present for backward compatibility, but deprecated in v1.13 (moby/moby#26834), and scheduled for removal in v17.12- Description for the changelog