Skip to content

Adds packaging for Fedora 27 - #59

Merged
seemethere merged 1 commit into
docker:masterfrom
seemethere:add_f27
Nov 21, 2017
Merged

seemethere merged 1 commit into
docker:masterfrom
seemethere:add_f27

Conversation

@seemethere

@seemethere seemethere commented Nov 14, 2017 •

Copy link
Copy Markdown
Contributor

Fedora 27 has hit GA! https://fedoramagazine.org/announcing-fedora-27/

Relies on: docker-library/official-images#3708

Relates to:

NOTE: The next release this is eligible for is 17.12.0-ce

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@@ -0,0 +1,17 @@
FROM fedora:27
RUN dnf -y upgrade
RUN dnf install -y @development-tools fedora-packager

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we follow best-practice here, and combine dnf -y upgrade with the dnf install lines? (I guess we don't use caching, so probably doesn't make a big difference)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah these aren't cached when we build packages since we build on freshly spawned slaves in the Jenkins setup, WDYT @andrewhsu?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a nit, definitely no blocker for this PR

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the builds work 😜

@seemethere

Copy link
Copy Markdown
Contributor Author

Can confirm I was able to successfully build packages after the merge of docker-library/official-images#3708

@trapier

trapier commented Nov 15, 2017 •

Copy link
Copy Markdown

Please also PR the docs when this is available. Would do it myself, but I don't know if F24 is still supported (and thus might need to be removed).

@ogajduse

Copy link
Copy Markdown

@trapier Fedora 24 hit the EOL on August 8th, 2017.

@seemethere
seemethere merged commit 3519a35 into docker:master Nov 21, 2017
@seemethere
seemethere deleted the add_f27 branch November 21, 2017 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants