Skip to content

Pass VERSION to engine static builds - #70

Merged
andrewhsu merged 1 commit into
docker:masterfrom
seemethere:pass_version_static
Dec 12, 2017
Merged

andrewhsu merged 1 commit into
docker:masterfrom
seemethere:pass_version_static

Conversation

@seemethere

Copy link
Copy Markdown
Contributor

VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas eli.uriegas@docker.com

VERSION file does not exist anymore for moby/moby so we need to
compensate

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
seemethere requested a review from a team December 12, 2017 00:08
@seemethere

Copy link
Copy Markdown
Contributor Author

Can confirm this works:

root@d5693c93984c:/v/static/build/linux/docker# ./dockerd --version
Docker version 17.12.0-ce-rc2, build 5d7e8f3

@andrewhsu andrewhsu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants