Skip to content

Downloading files and folders should preserve executable bit #112099

Description

Describe the bug
When you download a file from a remote (e.g. Codespaces), attributes such as the executable bit are removed. This is a (somewhat minor) annoyance when you are downloading files such as compiled binaries.

To Reproduce
Steps to reproduce the behavior with Codespaces:

  1. Within a codespace, create a file that has the executable bit set (e.g. touch foo && chmod +x foo).
  2. CMD+Click on the file and download it to your laptop
  3. The file will not have the executable bit locally so you need to run chmod +x foo again

Expected behavior
The executable bit should be preserved when downloading files.

https://github.com/microsoft/vssaas-planning/issues/1639

Activity

isidorn commented on Dec 8, 2020

@isidorn

Code pointer

operation.filesDownloaded++;

fyi Benjamin Pasero (@bpasero) since I believe you wrote the original download code and you might have ideas.
If not I can do some investagion...

bpasero commented on Dec 9, 2020

@bpasero
Contributor

Isidor Nikolic (@isidorn) this is not possible to implement with todays file system provider API. We would need to add group/permission/executable information to file system providers (Johannes Rieken (@jrieken)), otherwise we cannot restore this.

Some related issues: #48659, #71204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

feature-requestRequest for new features or functionalityfile-explorerExplorer widget issuesfile-ioFile I/O

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions