Skip to content

fix(search): fix expand all not working - #248207

Merged
Osvaldo Ortega (osortega) merged 2 commits into
microsoft:mainfrom
mortalYoung:fix/247812
May 9, 2025
Merged

Osvaldo Ortega (osortega) merged 2 commits into
microsoft:mainfrom
mortalYoung:fix/247812

Conversation

@mortalYoung

Copy link
Copy Markdown
Contributor

Expand All action don't need to expand a specific root node as the aims of the action is to expand all node.

fixed #247812

@osortega Osvaldo Ortega (osortega) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

野迂迂 (@mortalYoung) Thank you for this contribution! Left one comment

Comment thread src/vs/workbench/contrib/search/browser/searchActionsTopBar.ts Outdated

@osortega Osvaldo Ortega (osortega) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you ❤️

@vs-code-engineering vs-code-engineering Bot added this to the May 2025 milestone May 8, 2025
@osortega
Osvaldo Ortega (osortega) merged commit 85835f5 into microsoft:main May 9, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jun 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Expand All" doesnt work in the Search

3 participants