Skip to content

Fix vscode.env.onDidChangeShell not firing in the webworker extension host - #249824

Merged
Daniel Imms (Tyriar) merged 1 commit into
microsoft:mainfrom
jeanp413:fix-249823
Jun 2, 2025
Merged

Daniel Imms (Tyriar) merged 1 commit into
microsoft:mainfrom
jeanp413:fix-249823

Conversation

@jeanp413

Copy link
Copy Markdown
Contributor

Fixes #249823

@jeanp413

Copy link
Copy Markdown
Contributor Author

cc Megan Rogge (@meganrogge) as it's terminal related 🙂

@bpasero

Copy link
Copy Markdown
Contributor

I wonder how the one property can be different from the other 🤔

@jeanp413

Copy link
Copy Markdown
Contributor Author

Good point, currently remoteAuthority is empty for the web worker extension host context

@jeanp413

Copy link
Copy Markdown
Contributor Author

Seems that's intended for both webworker extension host and local extension host


@bpasero

Benjamin Pasero (bpasero) commented May 28, 2025 •

Copy link
Copy Markdown
Contributor

We have a bit more uses of IExtHostContext.remoteAuthority in the workbench and I wonder if these are all disfunct and should be using the environment service, do you want to adopt the others too?

@jeanp413

Jean Pierre (jeanp413) commented May 28, 2025 •

Copy link
Copy Markdown
Contributor Author

I see some usage in MainThreadMcp.ts but I think it's fine in that case as it's related where mpc servers are executed

@Tyriar
Daniel Imms (Tyriar) merged commit 1e6e3fe into microsoft:main Jun 2, 2025
@vs-code-engineering vs-code-engineering Bot locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vscode.env.onDidChangeShell not firing in the webworker extension host

5 participants