Skip content exclusion checks for apply_patch Add File

[monil-patel]

Summary

apply_patch can reject *** Add File operations when a repository has Copilot exclusions configured because the target does not exist yet.

This change makes apply_patch Add File behavior consistent with create_file:

• Continue to enforce allowedEditUris for every target.
• Reject Add File when the target already exists.
• Skip content-exclusion checks only after confirming that the Add File target does not exist.
• Preserve existing exclusion checks for UPDATE, DELETE, and move operations.

Testing

• npm run typecheck
• npm run test:unit -- src/extension/tools/test/node/applyPatch/applyPatch.spec.tsx

Added focused unit tests that verify:

• Add File succeeds without calling IIgnoreService.isCopilotIgnored.
• Add File outside allowedEditUris remains rejected before edits.
• Add File rejects an existing target without emitting edits.
• UPDATE operations continue to call the ignore service.
• Existing move tests continue to pass.

Test Files  1 passed
Tests       13 passed

Fixes #337528

[Copilot]

Copilot review overview

🟡 Changes recommended

The critical exclusion bypass for existing files must be fixed before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1

Open (1)

• ADD patches bypass existing-file checks for excluded targets · New

What changed in this PR

Updates apply_patch to permit new-file additions under content-based exclusion rules while retaining URI restrictions.

Changes:

• Skips exclusion checks for non-move ADD actions.
• Adds focused regression tests.

File	Review
extensions/​copilot/​src/​extension/​tools/​test/​node/​applyPatch/​applyPatch.spec.tsx	Adds coverage for additions, URI restrictions, updates, and moves.
extensions/​copilot/​src/​extension/​tools/​node/​applyPatchTool.tsx	Critical: ADD can target an existing excluded file and bypass exclusion checks; verify nonexistence or reject the operation.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[monil-patel]

Fixed in 94e948a. Add File now checks the target with IFileSystemService.stat() and rejects an existing file before skipping content exclusion. I also added a regression test with the existing target registered in the mock filesystem. The focused suite passes all 13 tests.

[monil-patel]

The remaining Linux / Electron-Smoke failure is an infrastructure timeout: the smoke-test step reached the workflow 20-minute limit without an assertion or code error. All compile, Copilot, unit, browser, remote, macOS, and Windows checks passed. I cannot rerun the job from a fork because GitHub requires repository admin rights. Please rerun the failed job when convenient.