firewall: move static rules pages to a legacy plugin

[fichtner]

Important notices

Our forum is located at https://forum.opnsense.org , please consider joining discussions there in stead of using GitHub for these matters.

Before you ask a new question, we ask you kindly to acknowledge the following:

• I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
• I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

TODO:

• rename old menu to legacy and new to "rules" 02c77e1
• add a plugin with firewall_rules.php and firewall_rules_edit.php a4995f6
• move default rules to new rules for this to make sense d9ac167
• keep migration page visible in the default installation (multiple commits show filter rules or outbound rules migration)
• at least src/opnsense/mvc/app/views/OPNsense/Firewall/group.volt seems to be referencing the old page still [26.1] Update links to point to new firewall rules UI #9672
• guard menu registrations so that they only show when plugin is installed 9d8c183 7fa3dee
• retain os-firewall-legacy on upgrades if filter.rules isn't empty yet (only if deemed necessary later)

[fichtner]

@AdSchellevis @Monviech given what is now implemented I doubt we even need to install the firewall legacy plugin... all the rules work after upgrade and the migration assistant is available to move them over and remove them. People not wanting to do that can install the plugin manually after upgrade. It simply holds the two www pages for rules and rules_edit. What do you think?

[AdSchellevis]

@fichtner on a clean install we certainly don't need it, but on an upgrade I expect quite some noise if the plugin isn't bootstrapped, but it could be an experiment, I'm just not 100% sure.

[Monviech]

Per default you can see all legacy rules in the new rules page, so theres no visibility loss if the legacy plugin isn't there. But it would look like they have been auto migrated and it might confuse more people than necessary. I would install it per default.

[fichtner]

If you hit the linked rule you get forwarded to the migration page. I thought it was pretty clever but we can do the safe approach too. Would just avoid installing when no rules are registered and therefore migration assistant not active anyway.

[AdSchellevis]

It's certainly clever, I also don't mind giving it a shot as an experiment, if it doesn't work out, we can reintroduce the auto-install later perhaps.

[Monviech]

Okay sounds like a plan :)