Repository navigation
Don't use %zx because it's unsupported on mingw64 - #578
Merged
Merged
Conversation
Also check that no warnings happen on travis
Contributor
|
Looks good i'm only not 100% sure if clang or other strict compiler will eat this. You should prefer adding a size to the cast so:
Then we are good to go. |
Contributor
Author
|
Ok... so after this PR:
clang accepted it, but I still made the change. Maybe there's a warning we can enable to enforce this? |
Contributor
|
Thank you for this improvement and understanding! |
Contributor
|
I'm not sure, probably GCC or some analyser have warned me some day about no defined typed, assuming int. |
6 tasks done
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also check that no warnings happen on travis
cc #569