Repository navigation
Fixed "unkown chip id", piped output and st-util -v - #763
Merged
Merged
Conversation
On Win32 redirecting streams makes them buffered, therefore without flushing there would be no output before exit. Stdout and stderr are also often buffered differently, making them disordered.
Contributor
|
Thanks! |
This was
linked to
issues
Mar 18, 2020
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small tweaks.
flushing there would be no output before exit, resulting in [st-util] Can not get piped output on Windows #665. BTW using setvbuf to force the streams into line buffered mode doesn't work on Win32.