Repository navigation
Percent effect starts by zero at every value change #4934
Description
What happened?
Since last update the percent effect starts at zero instead of the last value.
i use this effect with two presets to light my stairs.
in the previous firmware it moved from 100 to 0 percent backwards. now it turns immediately to zero.
My presets below.
To Reproduce Bug
Preset 1 (Turns the lights on):
{"on":true,"bri":47,"transition":1,"mainseg":0,"seg":[{"id":0,"start":0,"stop":307,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[117,71,36,0],[0,0,0,0],[0,0,0,0]],"fx":98,"sx":15,"ix":100,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":false,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0},{"id":1,"start":307,"stop":726,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[117,71,36,0],[0,0,0,0],[0,0,0,0]],"fx":98,"sx":18,"ix":100,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":true,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0}]}
Preset 2 (turns the leds off):
{"on":true,"bri":47,"transition":7,"mainseg":0,"seg":[{"id":0,"start":0,"stop":307,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[117,71,36,0],[0,0,0,0],[0,0,0,0]],"fx":98,"sx":15,"ix":0,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":false,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0},{"id":1,"start":307,"stop":726,"grp":1,"spc":0,"of":0,"on":true,"frz":false,"bri":255,"cct":127,"set":0,"col":[[117,71,36,0],[0,0,0,0],[0,0,0,0]],"fx":98,"sx":18,"ix":0,"pal":0,"c1":128,"c2":128,"c3":16,"sel":true,"rev":true,"mi":false,"o1":false,"o2":false,"o3":false,"si":0,"m12":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0},{"stop":0}]}
Expected Behavior
effect (preset 2 as given) should move backwards from 100 to zero instead of turning all leds off.
Install Method
Binary from WLED.me
What version of WLED?
V0.15.1 "Kösen" Build 2507300
Which microcontroller/board are you seeing the problem on?
ESP32-S2
Relevant log/trace output
Anything else?
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
[-]Percent effect starts by zero at every valie change[/-][+]Percent effect starts by zero at every value change[/+]DedeHai commentedon Sep 14, 2025
there were no changes to that effect in 3 years...
I added the speed slider back recently, check nightly build.
LOGOLEX commentedon Sep 16, 2025
i've downgraded to v0.14.3 and it works again.
never change a running system...
pipetboy commentedon Sep 17, 2025
I'm seeing the same issue ever since V15.1
I'm using it to visualize a timer. In V14 it would just increase a few pixels per second, now it turns off completly then all requested pixels light up quickly, from 0.
blazoncek commentedon Sep 17, 2025
Most likely caused by
resetIfRequired().DedeHai commentedon Sep 17, 2025
I can take a look at this. @pipetboy Is this issue also present in nightly build or just 0.15.1?
DedeHai commentedon Sep 17, 2025
I checked nightly, this bug is not present.
DedeHai commentedon Sep 17, 2025
can confirm it does not work in 0.15.1, but IMHO the ship has sailed for 0.15 to fix such bugs. If anyone wants to hunt it down and fix it for the 0.15.2 release, please feel free to submit a PR.
MaxVonEvil commentedon Sep 22, 2025
Would love to see this get fixed in 15.2. Usecase: I have 180 led's around the rim of a kinetic sand table and I wanted to use it as a progress indicator in some cases. It gradually turns on the light around the table as the pattern drawing progresses. I got all the logic and API worked out, yet the current turning-off-before-update gives an annoying "flinch" experience, for lack of a better word. Thanks!
DedeHai commentedon Sep 23, 2025
@MaxVonEvil you can use 0.16 (nightly build)
DedeHai commentedon Sep 28, 2025
since 0.16 will most likely have restrictions in terms of led count on ESP8266 and 0.15.x may be the final stop for some setups, I fixed it.
MaxVonEvil commentedon Sep 28, 2025