[Piyushrathoree]

Objective

Fixes #63954

On Linux with client-side decorations, the window controls (close / minimize / maximize) move 1px up and outward when the agent sidebar is opened, and move back when it is closed.

Solution

The title bar draws a 1px border in its own color to cover the window border at the rounded corners, so the controls it renders sit 1px in from the edge. When the sidebar is open, Sidebar::render_sidebar_header renders the same controls without that inset.

Added the matching 1px padding to the sidebar header under Decorations::Client: top always, bottom only when no project is open (otherwise the header's bottom border already accounts for it), and left/right only on the side that renders the controls.

Testing

Compared the close button position with the sidebar closed and open, on stable 1.20.2 and on this branch, in a floating and a maximized window. Before: moves by (-1, -1) px. After: stays on the same pixel in both cases.

Tested on Fedora 44, GNOME on Wayland, with window buttons on the left. Not tested with buttons on the right.

Validated with:

• cargo build
• cargo test -p sidebar
• ./script/clippy -p sidebar
• cargo fmt -p sidebar

Before:

After:

Self-Review Checklist

• I've reviewed my own diff for quality, security, and reliability
• Unsafe blocks (if any) have justifying comments
• The content adheres to Zed's UI standards
• Tests cover the new/changed behavior
• Performance impact has been considered and is acceptable

---

Release Notes:

• Fixed window controls shifting by 1px when the agent sidebar is open on Linux.

[legregz]

I noticed that the corner of the window moves, too, but maybe you've already noticed that?

[Piyushrathoree]

I noticed that the corner of the window moves, too, but maybe you've already noticed that?

hey actually I checked your issue , and then reproduce and raised the pr

[smitbarmase]

Thanks! Upon testing this, I noticed the window controls were still shifting by a pixel when switching to the threads archive view, so I applied the same fix there as well.

I also moved the insets into an apply_title_bar_insets helper so all the headers stay in sync with the title bar.

Thanks again.

[Piyushrathoree]

Thanks! Upon testing this, I noticed the window controls were still shifting by a pixel when switching to the threads archive view, so I applied the same fix there as well.

I also moved the insets into an apply_title_bar_insets helper so all the headers stay in sync with the title bar.

Thanks again.

thanks