Repository navigation
markdown: Fix code block scrollbar track leaking past rounded corners - #64978
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
MrSubidubi
previously requested changes
Sep 30, 2026
3 tasks done
SomeoneToIgnore
approved these changes
Oct 7, 2026
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one small NIT found.
smitbarmase
enabled auto-merge
October 7, 2026 16:15
3 tasks done
kaihere14
pushed a commit
to kaihere14/zed
that referenced
this pull request
Oct 13, 2026
…stries#65358) ## Summary - Removes unwanted radius on agent terminal introduced in zed-industries#64978 and called out in zed-industries#64328 (review) - Removes space above scrollbar in terminal and under header. <img width="1002" height="692" alt="668920502-53393680-2767-44f9-98dc-0910c34bdfb2" src="https://github.com/user-attachments/assets/babed1ab-fe80-4235-ba4f-decb7aea95bd" /> ## Testing Built and tested locally. ## Self-review - [X] I've reviewed my diff for quality, security, reliability, and performance. - [X] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [X] Tests cover the new or changed behavior. Release Notes: - Removed extra rounded corner on terminal in agent pane when a scrollbar is present and removed space between scrollbar and terminal header. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
amirkhakshour
pushed a commit
to SourceShift/zed-mini-ork
that referenced
this pull request
Oct 18, 2026
…stries#65358) ## Summary - Removes unwanted radius on agent terminal introduced in zed-industries#64978 and called out in zed-industries#64328 (review) - Removes space above scrollbar in terminal and under header. <img width="1002" height="692" alt="668920502-53393680-2767-44f9-98dc-0910c34bdfb2" src="https://github.com/user-attachments/assets/babed1ab-fe80-4235-ba4f-decb7aea95bd" /> ## Testing Built and tested locally. ## Self-review - [X] I've reviewed my diff for quality, security, reliability, and performance. - [X] UI changes follow the [checklist](https://zed.dev/docs/development/ui-checklist). - [X] Tests cover the new or changed behavior. Release Notes: - Removed extra rounded corner on terminal in agent pane when a scrollbar is present and removed space between scrollbar and terminal header. --------- Co-authored-by: Smit Barmase <heysmitbarmase@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hovering a horizontally scrollable code block, the scrollbar track was painted with square corners. Since GPUI content masks are rectangular, the parent's rounded border didn't clip it, so a small corner of the track showed outside the code block's rounded border.
This adds
Scrollbars::track_corner_radiusto round the track's outer corners, and markdown code blocks now pass their inner corner radius (corner radius minus border width).Before:
After:
Release Notes: