Repository navigation
markdown_preview: Make markdown preview clone and splittable - #65136
Merged
SomeoneToIgnore merged 4 commits intoOct 5, 2026
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
osiewicz
approved these changes
Oct 5, 2026
osiewicz
left a comment
osiewicz
left a comment
Member
There was a problem hiding this comment.
Thank you for submitting a PR and using Zed. Your submission looks good to me. :)
MrSubidubi
changed the title
MrSubidubi
reviewed
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #36790
Closes #63076 (duplicate)
A focused markdown preview ignored keyboard pane-split shortcuts because
MarkdownPreviewViewdidn't implementItem::can_split/Item::clone_on_split.This implements both methods so a preview splits like any other pane item.
Screen.Recording.2026-10-04.at.4.10.45.PM.mov
Testing
Added
splitting_preview_clones_into_new_pane: it opens a file and its preview, callsWorkspace::split_and_clone, and asserts the split succeeds and the new pane's active item is aMarkdownPreviewView.cargo test -p markdown_previewpasses.To verify manually:
.mdfile and open its Markdown Preview.manually tested on macOS 26.6.1, M4
Self-review
Release Notes:
cmd-\,cmd-k ...) when focused