Skip to content

Conversation

@ry4nz
Copy link
Contributor

@ry4nz ry4nz commented Mar 5, 2019

Signed-off-by: Ryan Zhang [email protected]

- What I did
Export types in cli/command/config so it can be used externally.

- How I did it
Exported the types

- How to verify it
should be covered by existing tests

- Description for the changelog
Export types in cli/command/config so it can be used externally.

- A picture of a cute animal (not mandatory but encouraged)
img-5352

Signed-off-by: Ryan Zhang <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #1717 into master will not change coverage.
The diff coverage is 97.5%.

@@           Coverage Diff           @@
##           master    #1717   +/-   ##
=======================================
  Coverage   56.16%   56.16%           
=======================================
  Files         306      306           
  Lines       21016    21016           
=======================================
  Hits        11803    11803           
  Misses       8359     8359           
  Partials      854      854

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

ping @silvin-lubecki @vdemeester PTAL

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants