chore: move fqn to import#3197
Conversation
Summary of ChangesHello @robfrank, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant code refactoring effort aimed at improving the overall maintainability and clarity of the codebase. By converting fully qualified class names to standard import statements, the changes make the code easier to read and understand without altering any functional behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🧪 CI InsightsHere's what we observed from your CI run for b9e2cc8. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Code Review
The pull request successfully refactors the codebase by replacing fully qualified names (FQNs) with import statements across multiple files. This change significantly improves code readability and maintainability by reducing verbosity and making the code cleaner. The refactoring is consistently applied throughout the affected files, demonstrating a thorough approach to code clarity. No functional regressions or new issues are introduced by these changes.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
(cherry picked from commit 139d72f)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.30.6 to 4.30.8. Release notes *Sourced from [github/codeql-action's releases](https://github.com/github/codeql-action/releases).* > v4.30.8 > ------- > > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > 4.30.8 - 10 Oct 2025 > -------------------- > > No user facing changes. > > See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v4.30.8/CHANGELOG.md) for more information. > > v4.30.7 > ------- > > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > 4.30.7 - 06 Oct 2025 > -------------------- > > * [v4+ only] The CodeQL Action now runs on Node.js v24. [ArcadeData#3169](https://redirect.github.com/github/codeql-action/pull/3169) > > See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v4.30.7/CHANGELOG.md) for more information. > > v3.30.8 > ------- > > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > 3.30.8 - 10 Oct 2025 > -------------------- > > No user facing changes. > > See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.30.8/CHANGELOG.md) for more information. > > v3.30.7 > ------- > > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > 3.30.7 - 06 Oct 2025 > -------------------- > > No user facing changes. > > See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.30.7/CHANGELOG.md) for more information. Changelog *Sourced from [github/codeql-action's changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md).* > CodeQL Action Changelog > ======================= > > See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. > > [UNRELEASED] > ------------ > > No user facing changes. > > 4.30.8 - 10 Oct 2025 > -------------------- > > No user facing changes. > > 4.30.7 - 06 Oct 2025 > -------------------- > > * [v4+ only] The CodeQL Action now runs on Node.js v24. [ArcadeData#3169](https://redirect.github.com/github/codeql-action/pull/3169) > > 3.30.6 - 02 Oct 2025 > -------------------- > > * Update default CodeQL bundle version to 2.23.2. [ArcadeData#3168](https://redirect.github.com/github/codeql-action/pull/3168) > > 3.30.5 - 26 Sep 2025 > -------------------- > > * We fixed a bug that was introduced in `3.30.4` with `upload-sarif` which resulted in files without a `.sarif` extension not getting uploaded. [ArcadeData#3160](https://redirect.github.com/github/codeql-action/pull/3160) > > 3.30.4 - 25 Sep 2025 > -------------------- > > * We have improved the CodeQL Action's ability to validate that the workflow it is used in does not use different versions of the CodeQL Action for different workflow steps. Mixing different versions of the CodeQL Action in the same workflow is unsupported and can lead to unpredictable results. A warning will now be emitted from the `codeql-action/init` step if different versions of the CodeQL Action are detected in the workflow file. Additionally, an error will now be thrown by the other CodeQL Action steps if they load a configuration file that was generated by a different version of the `codeql-action/init` step. [ArcadeData#3099](https://redirect.github.com/github/codeql-action/pull/3099) and [ArcadeData#3100](https://redirect.github.com/github/codeql-action/pull/3100) > * We added support for reducing the size of dependency caches for Java analyses, which will reduce cache usage and speed up workflows. This will be enabled automatically at a later time. [ArcadeData#3107](https://redirect.github.com/github/codeql-action/pull/3107) > * You can now run the latest CodeQL nightly bundle by passing `tools: nightly` to the `init` action. In general, the nightly bundle is unstable and we only recommend running it when directed by GitHub staff. [ArcadeData#3130](https://redirect.github.com/github/codeql-action/pull/3130) > * Update default CodeQL bundle version to 2.23.1. [ArcadeData#3118](https://redirect.github.com/github/codeql-action/pull/3118) > > 3.30.3 - 10 Sep 2025 > -------------------- > > No user facing changes. > > 3.30.2 - 09 Sep 2025 > -------------------- > > * Fixed a bug which could cause language autodetection to fail. [ArcadeData#3084](https://redirect.github.com/github/codeql-action/pull/3084) > * Experimental: The `quality-queries` input that was added in `3.29.2` as part of an internal experiment is now deprecated and will be removed in an upcoming version of the CodeQL Action. It has been superseded by a new `analysis-kinds` input, which is part of the same internal experiment. Do not use this in production as it is subject to change at any time. [ArcadeData#3064](https://redirect.github.com/github/codeql-action/pull/3064) > > 3.30.1 - 05 Sep 2025 > -------------------- > > * Update default CodeQL bundle version to 2.23.0. [ArcadeData#3077](https://redirect.github.com/github/codeql-action/pull/3077) > > 3.30.0 - 01 Sep 2025 > -------------------- > > * Reduce the size of the CodeQL Action, speeding up workflows by approximately 4 seconds. [ArcadeData#3054](https://redirect.github.com/github/codeql-action/pull/3054) > > 3.29.11 - 21 Aug 2025 > --------------------- ... (truncated) Commits * [`f443b60`](github/codeql-action@f443b60) Merge pull request [ArcadeData#3198](https://redirect.github.com/github/codeql-action/issues/3198) from github/update-v4.30.8-527f0f324 * [`7a2cb62`](github/codeql-action@7a2cb62) Update changelog for v4.30.8 * [`527f0f3`](github/codeql-action@527f0f3) Merge pull request [ArcadeData#3195](https://redirect.github.com/github/codeql-action/issues/3195) from github/dependabot/npm\_and\_yarn/npm-minor-37415c... * [`f402506`](github/codeql-action@f402506) Merge pull request [ArcadeData#3196](https://redirect.github.com/github/codeql-action/issues/3196) from github/dependabot/github\_actions/dot-github/wor... * [`f5e53f9`](github/codeql-action@f5e53f9) Merge pull request [ArcadeData#3197](https://redirect.github.com/github/codeql-action/issues/3197) from github/dependabot/github\_actions/dot-github/wor... * [`4e90a42`](github/codeql-action@4e90a42) Merge pull request [ArcadeData#3193](https://redirect.github.com/github/codeql-action/issues/3193) from github/mbg/ff/tools-toolcache * [`413a4a4`](github/codeql-action@413a4a4) Rebuild * [`4521864`](github/codeql-action@4521864) Bump github/codeql-action from 3 to 4 in /.github/workflows * [`eadf14b`](github/codeql-action@eadf14b) Bump ruby/setup-ruby * [`e1257b6`](github/codeql-action@e1257b6) Rebuild * Additional commits viewable in [compare view](github/codeql-action@64d10c1...f443b60) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
move fqn to import