fix(tui): make Ctrl+O inspector complete and draft-safe#4498
Conversation
|
Exact-head local gate update for 2883f95: cargo check -p codewhale-tui --bin codewhale-tui --locked passed. The branch is clean and tracking origin/agent/091-tui-regressions. |
|
Follow-up review fixes are public at exact head f62e0d2: Caps Lock plus Ctrl+O now stays on the inspector, external-editor routing requires explicit Shift and has an F4 fallback for legacy terminals, c/y uses a source-faithful Turn Inspector payload (indentation, tabs, repeated/blank lines retained), and blank display rows are no longer doubled. Focused shortcut, 36 pager tests, long-result regression, locked binary check, fmt, and diff check pass. CI restarted on this head. |
f62e0d2 to
227d0e5
Compare
|
Rebased onto public |
|
Pushed follow-up |
|
Public handoff update: pushed exact head |
|
Correction to the preceding comment: the exact remote head is |
Route Ctrl+O to the Turn Inspector regardless of composer contents, move external-editor access to Ctrl+Shift+O, and retain complete final responses in the pager while keeping exported handoffs compact. Co-authored-by: Sh1Zuku <125943630+SparkofSpike@users.noreply.github.com> Signed-off-by: Hunter B <hmbown@gmail.com>
Keep Caps Lock from routing Ctrl+O to the editor, provide F4 where legacy terminals cannot distinguish Ctrl+Shift+O, and preserve source-faithful Turn Inspector clipboard content including indentation and blank lines. Signed-off-by: Hunter B <hmbown@gmail.com>
Use a piped stdin for both foreground and background hooks, dropping the writer immediately when no payload exists. This provides portable EOF through cmd and PowerShell, where a NUL handle can be reopened as console input and hang the hook.\n\nRefs #4489. Signed-off-by: Hunter B <hmbown@gmail.com>
Signed-off-by: Hunter B <hmbown@gmail.com>
10834f5 to
44cddb8
Compare
|
Rebased onto public |
|
Correction: the exact remote head is |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
Summary
Fixes #4482.
Verification
Release note
This PR is intentionally scoped to the reproducible Ctrl+O failures. The separate intermittent Windows repaint report in #4479 remains open until its terminal/version evidence supports a narrow fix rather than a speculative repaint loop.