Modify: Default Height on Chat List#3319
Merged
Merged
Conversation
CertifiedJoon
marked this pull request as ready for review
June 7, 2023 04:11
CertifiedJoon
requested review from
AbdBarho,
andreaskoepf,
notmd and
yk
as code owners
June 7, 2023 04:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3305
/chat
I thought that it was intuitive to set height to of chat list to zero when there is no chats on the list.
But, as soon as a chat has been added to the list, I have set the default height.
/chat/{id}
I thought it is counter-intuitive to set default height to zero on this page. I have set default height to hundered percent.