Skip to content

fix chat list double scrollbar#3385

Merged
AbdBarho merged 4 commits into
mainfrom
fix_chat_list_double_scrollbar
Jun 11, 2023
Merged

fix chat list double scrollbar#3385
AbdBarho merged 4 commits into
mainfrom
fix_chat_list_double_scrollbar

Conversation

@notmd

@notmd notmd commented Jun 11, 2023

Copy link
Copy Markdown
Collaborator

close #3252

  • Dont render scrollbar in /chat page anymore.
  • Fix an overflow bug in the chat list

I have manually verified all the UI

@github-actions

Copy link
Copy Markdown

pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

@notmd
notmd marked this pull request as draft June 11, 2023 15:14
Comment on lines +309 to +310
as="div"
role="button"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this bug
validateDOMNesting(...): <button> cannot appear as a descendant of <button>.

@notmd
notmd marked this pull request as ready for review June 11, 2023 15:48

@AbdBarho AbdBarho left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AbdBarho
AbdBarho merged commit 1c50662 into main Jun 11, 2023
@AbdBarho
AbdBarho deleted the fix_chat_list_double_scrollbar branch June 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chat list scrollbar UI regression

2 participants