Added confirmation dialog when skipping after entering text#3479
Merged
Conversation
MehrJonas
requested review from
AbdBarho,
andreaskoepf,
notmd and
yk
as code owners
June 15, 2023 20:55
notmd
reviewed
Jun 16, 2023
| "sign_in": "Sign In", | ||
| "sign_out": "Sign Out", | ||
| "skip": "Skip", | ||
| "skip_confirmation": "Are you sure you want to skip?", |
Collaborator
There was a problem hiding this comment.
Can you move this to task.json file?
notmd
reviewed
Jun 16, 2023
|
|
||
| const onClick = () => { | ||
| if (props.confirmSkip) { | ||
| showModal(); |
Collaborator
There was a problem hiding this comment.
Also can you only show the modal when the input is not empty?
Contributor
Author
There was a problem hiding this comment.
I'm already doing that... that's what the confirmSkip flag is for. I'm setting that to true if taskstatus.replyValidity === "VALID" (see TaskControls.tsx), which corresponds to a non-empty reply field.
notmd
approved these changes
Jun 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a dialog asking the user to confirm whether they want to skip a question after they have already entered text to prevent accidentally losing an answer by clicking the wrong button as requested in #2778