Update profile image on login#3491
Merged
Merged
Conversation
notmd
reviewed
Jun 18, 2023
| session.user.role = token.role; | ||
| session.user.isNew = token.isNew; | ||
| session.user.name = token.name; | ||
| session.user.image = token.picture; |
Collaborator
There was a problem hiding this comment.
You can receive image from user property in the callback here
Collaborator
Author
There was a problem hiding this comment.
you mean the user object which is given as a parameter to the session callback?
the user object is only passed if we are using the database strategy, but we are using jwt.
Or did I misunderstand what you say?
Collaborator
There was a problem hiding this comment.
the
userobject is only passed if we are using the database strategy, but we are using jwt.
Hmm I don't see where the docs mention this, the TS signature doesn't mark it as nullable as well.
Collaborator
Author
There was a problem hiding this comment.
if I console log it is undefined, would be a lot easier if we did not have to pass everything though the token.
notmd
approved these changes
Jun 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2196 (not only for discord, but all providers)
Instead of doing the big mess of having to refresh images in the background, we update the images when the user signs in, from the profile we get from the provider.
This has the side effect that if you have 2 different images on 2 different login providers, your image will always change depending on the last provider you logged in with, but I think this is ok.
Also, consolidate all of the updates that are applied to the user to one database call.