Add: option to view plaintext chat message. Issue/2508#3496
Merged
Conversation
notmd
reviewed
Jun 19, 2023
| const [isEditing, setIsEditing] = useBoolean(false); | ||
| const [isPlainText, setIsPlainText] = useState<boolean>(false); | ||
| const inputRef = useRef<HTMLTextAreaElement>(null); | ||
| const memoIsPlainText = useMemo(() => isPlainText, [isPlainText]); |
Collaborator
There was a problem hiding this comment.
This probably has no effect, you can remove this.
Contributor
Author
There was a problem hiding this comment.
noted. i have made the change.
CertifiedJoon
changed the title
CertifiedJoon
marked this pull request as ready for review
June 20, 2023 09:04
CertifiedJoon
requested review from
AbdBarho,
andreaskoepf and
yk
as code owners
June 20, 2023 09:04
notmd
reviewed
Jun 20, 2023
| )} | ||
| {state === "complete" && ( | ||
| <> | ||
| <BaseMessageEmojiButton |
Collaborator
There was a problem hiding this comment.
Can you adjust icon base on the isPlainText state? I think using these two icons will make more sense
https://tabler-icons.io/i/markdown-off
https://tabler-icons.io/i/markdown
Just copy the SVG, we don't need to install the lib
Contributor
Author
There was a problem hiding this comment.
noted. have made the relevant changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2508
Rendered by suspense
Plain text
I am not sure whether using memo on isPlainText has any performance gain. I need your opinions.