Update Flash Attention forward for Llama 2: #3595
Merged
Merged
Conversation
…P have been added.
jordiclive
requested review from
andreaskoepf,
dvruette,
sanagno,
shahules786,
theblackcat102 and
yk
as code owners
July 23, 2023 07:15
andreaskoepf
approved these changes
Jul 23, 2023
andreaskoepf
left a comment
andreaskoepf
left a comment
Collaborator
There was a problem hiding this comment.
Very cool thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GQA for 34B and 70B and tp have been added
The current flash attn patch forward is for the old transformers' attention forward.