Custom instructions feature#3597
Merged
draganjovanovich merged 6 commits intoJul 30, 2023
Merged
Conversation
It utilises two additional fields in work_parameters: - user_profile (here user would describe what he wants to share with llm, for chat session) - user_response_instructions (here user would describe how want to llm respond to questions and queries, like format, style, lengt etc...)
It utilises two additional fields in work_parameters: - user_profile (here user would describe what he wants to share with llm, for chat session) - user_response_instructions (here user would describe how want to llm respond to questions and queries, like format, style, lengt etc...)
draganjovanovich
marked this pull request as ready for review
July 23, 2023 22:06
draganjovanovich
requested review from
AbdBarho,
andreaskoepf,
melvinebenezer,
notmd,
olliestanley and
yk
as code owners
July 23, 2023 22:06
Co-authored-by: Oliver Stanley <olivergestanley@gmail.com>
olliestanley
approved these changes
Jul 25, 2023
olliestanley
left a comment
olliestanley
left a comment
Collaborator
There was a problem hiding this comment.
Inference backend/worker changes lgtm (have not reviewed frontend changes)
notmd
approved these changes
Jul 29, 2023
notmd
left a comment
notmd
left a comment
Collaborator
There was a problem hiding this comment.
I haven't run the code yet but overall it looks good. Just one small thing to clean up the code and avoid re-render. Feel free to merge if you can't make it work with react-hook-form.
Comment on lines
+114
to
+117
| const [customInstructions, setCustomInstructions] = useState<CustomInstructionsType>({ | ||
| user_profile: "", | ||
| user_response_instructions: "", | ||
| }); |
Collaborator
There was a problem hiding this comment.
This state can be handled by react-hook-form. You just need to wrap the CustomInstructions with the Controller component.
Collaborator
Author
There was a problem hiding this comment.
Thanks, could you please provide a commit/change for that here if you have time and it's small(I am not sure how to wrap it with Controller)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added basic functionality of "custom-instructions"
It utilises two additional fields in work_parameters:
llm, for chat session)
respond to questions and queries, like format, style, length, etc...)
Here are some of the current UI changes introduced with this PR.
Custom instructions