Skip to content

Add paper acknowledgement form#3637

Merged
andreaskoepf merged 2 commits into
mainfrom
paperack
Aug 8, 2023
Merged

Add paper acknowledgement form#3637
andreaskoepf merged 2 commits into
mainfrom
paperack

Conversation

@yk

@yk yk commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

I know all of this is suboptimal, but I'd like to get people to sign up to be mentioned asap. Feel free to improve (or to tell me how to improve) now or in subsequent PRs. I anticipate this form will be going away in the future, so I'm not sure a lot of work will be really worth it.

@AbdBarho

AbdBarho commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

Hey sorry I have guests over I will try to give it a look in the evening, what is the context for this? is it required as part of the paper submission?

@yk

yk commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator Author

Hey sorry I have guests over I will try to give it a look in the evening, what is the context for this? is it required as part of the paper submission?

It's not required, no. But it would be nice to acknowledge contributors. So it's not a super stress, but we should get it going in the next days.

@AbdBarho

AbdBarho commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

Would it make sense to allow the users to change their user name, and then make the leaderboard public? with all users with more than 0 points?

@yk

yk commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator Author

Would it make sense to allow the users to change their user name, and then make the leaderboard public? with all users with more than 0 points?

we could do that as well, but for a lot of people I think it would be cool to see their name listed in a published paper.

@AbdBarho

AbdBarho commented Aug 6, 2023

Copy link
Copy Markdown
Collaborator

Oh, of course, that was my intention as well, my proposal was to read from the leaderboards, but I guess we would need consent and a "real" name anyway, so no problem.

I took the liberty of cleaning up some stuff so it is not a "hack" anymore, I hope you are fine with that

Although the database changes are not the best, it is not a problem since they should be only temporary.

Please note: we still use npx prisma db push which just overwrites the db schema for our deployment

npx prisma db push --skip-generate

So adding columns is okay, migrations still not there yet, even though I added something in #3488, it was never merged.

@AbdBarho AbdBarho changed the title DIRTY HACK: Add paper acknowledgement form Add paper acknowledgement form Aug 6, 2023

@andreaskoepf andreaskoepf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, nice.

@andreaskoepf
andreaskoepf merged commit 80c9ca5 into main Aug 8, 2023
@andreaskoepf
andreaskoepf deleted the paperack branch August 8, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants