To support pip install for model_training package.#3643
Merged
Conversation
zhanglu0704
requested review from
andreaskoepf,
dvruette,
jordiclive,
sanagno,
shahules786,
theblackcat102 and
yk
as code owners
August 8, 2023 03:56
andreaskoepf
approved these changes
Aug 8, 2023
andreaskoepf
left a comment
andreaskoepf
left a comment
Collaborator
There was a problem hiding this comment.
Very interesting that it worked so far with py-modules instead of packages. Thanks for the fix.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Python module: model_training, the original package management file pyproject.toml was configured with "py-modules = ["model_training"]". However, "py-modules" is typically used for setting up single file modules, not for Python packages. The original configuration could possibly cause "pip install ." to fail to install model_training in the Python environment (only model_training-1.0.0.dist-info is available under /usr/local/lib/python/).