[None][fix] Fix kv_layout for FLASHINFER backend#13190
Conversation
|
/bot run |
📝 WalkthroughWalkthroughTwo files updated: flashinfer attention backend now enforces tensor contiguity during ragged prefill kernel execution; modeling_radio refactors attention metadata initialization to conditionally set kv_layout for FLASHINFER backend while preserving defaults for others. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/attention_backend/flashinfer.py (1)
1-1:⚠️ Potential issue | 🟠 MajorAdd NVIDIA copyright header to this modified source file.
This file is modified, but Line 1 begins directly with imports and has no required header.
💡 Proposed fix
+# Copyright (c) 2025-2026, NVIDIA CORPORATION. All rights reserved. + import mathAs per coding guidelines, "All TensorRT-LLM source files must contain an NVIDIA copyright header with the year of latest meaningful modification".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tensorrt_llm/_torch/attention_backend/flashinfer.py` at line 1, This file (flashinfer.py) is missing the required NVIDIA copyright header at the top; add the standard NVIDIA copyright header comment block including the year of latest meaningful modification and the project/license statement as per coding guidelines, placing it as the very first lines of tensorrt_llm/_torch/attention_backend/flashinfer.py before any imports (ensure the header includes the current year and matches the project's canonical header format).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tensorrt_llm/_torch/attention_backend/flashinfer.py`:
- Line 1: This file (flashinfer.py) is missing the required NVIDIA copyright
header at the top; add the standard NVIDIA copyright header comment block
including the year of latest meaningful modification and the project/license
statement as per coding guidelines, placing it as the very first lines of
tensorrt_llm/_torch/attention_backend/flashinfer.py before any imports (ensure
the header includes the current year and matches the project's canonical header
format).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 319760c2-858d-428b-8ab7-e15833df5a39
📒 Files selected for processing (2)
tensorrt_llm/_torch/attention_backend/flashinfer.pytensorrt_llm/_torch/models/modeling_radio.py
|
/bot run |
|
PR_Github #44489 [ run ] triggered by Bot. Commit: |
|
PR_Github #44489 [ run ] completed with state
|
5890a85 to
0b27ffa
Compare
|
/bot run |
|
PR_Github #44537 [ run ] triggered by Bot. Commit: |
|
PR_Github #44537 [ run ] completed with state
|
|
/bot run |
|
PR_Github #44617 [ run ] triggered by Bot. Commit: |
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
Signed-off-by: yechank <161688079+yechank-nvidia@users.noreply.github.com>
0b27ffa to
a7863a5
Compare
|
/bot run |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
|
/bot kill |
👎 Promotion blocked, new vulnerability foundVulnerability report
|
|
/bot run |
|
PR_Github #44673 [ run ] triggered by Bot. Commit: |
|
PR_Github #44673 [ run ] completed with state
|
|
/bot run |
|
PR_Github #44749 [ run ] triggered by Bot. Commit: |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "Prior pipeline passed all stages except B200 which is undergoing maintenance" |
|
PR_Github #44789 [ skip ] triggered by Bot. Commit: |
|
PR_Github #44789 [ skip ] completed with state |
Summary by CodeRabbit
Release Notes
Bug Fixes
Refactor