[https://nvbugs/6074943][fix] Disable new aiperf server metrics to stop hang.#13314
Conversation
Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
📝 WalkthroughWalkthroughAdded the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/stress_test/stress_test.py (1)
1-1:⚠️ Potential issue | 🟡 MinorUpdate the NVIDIA copyright year in this modified file.
This header still ends at 2024, but this file has meaningful 2026 changes. Please update the year range accordingly.
As per coding guidelines "Add NVIDIA copyright header on ALL new files and update year on modified files" and "All TensorRT-LLM source files must contain an NVIDIA copyright header with the year of latest meaningful modification".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/stress_test/stress_test.py` at line 1, Update the SPDX header year range in the file's top comment from "2022-2024" to include the latest meaningful modification year (change "2022-2024" to "2022-2026") so the NVIDIA copyright header reflects the 2026 changes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/integration/defs/stress_test/stress_test.py`:
- Line 1: Update the SPDX header year range in the file's top comment from
"2022-2024" to include the latest meaningful modification year (change
"2022-2024" to "2022-2026") so the NVIDIA copyright header reflects the 2026
changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e7152f01-b48d-4c0a-bdb2-718b05b1237a
📒 Files selected for processing (1)
tests/integration/defs/stress_test/stress_test.py
|
/bot run --stage-list "A10-PyTorch-Post-Merge-1" |
|
PR_Github #44879 [ run ] triggered by Bot. Commit: |
|
PR_Github #44879 [ run ] completed with state |
|
/bot run |
|
PR_Github #44929 [ run ] triggered by Bot. Commit: |
|
PR_Github #44929 [ run ] completed with state
|
|
/bot run |
|
PR_Github #45078 [ run ] triggered by Bot. Commit: |
|
PR_Github #45078 [ run ] completed with state
|
|
/bot run |
|
PR_Github #45125 [ run ] triggered by Bot. Commit: |
crazydemo
left a comment
There was a problem hiding this comment.
This PR fixes the aiperf issue.
|
PR_Github #45125 [ run ] completed with state |
…op hang. (NVIDIA#13314) Signed-off-by: Wangshanshan <30051912+dominicshanshan@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.