Skip to content

[None][doc] update verbose comments#13387

Merged
VALLIS-NERIA merged 2 commits into
NVIDIA:mainfrom
VALLIS-NERIA:VALLIS-NERIA-patch-4
Apr 24, 2026
Merged

[None][doc] update verbose comments#13387
VALLIS-NERIA merged 2 commits into
NVIDIA:mainfrom
VALLIS-NERIA:VALLIS-NERIA-patch-4

Conversation

@VALLIS-NERIA

@VALLIS-NERIA VALLIS-NERIA commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Updated skip condition messages in backend performance tests for improved clarity.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
@VALLIS-NERIA
VALLIS-NERIA requested a review from a team as a code owner April 23, 2026 16:23
Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Test skip messages for H20 GPU TRITON MXFP4 MoE backend were simplified from detailed descriptions ("51x slower", "ptxas OCG bug") to a concise "perf issue" phrasing, while preserving the bug reference and CUDA version note in both 1-GPU and 4-GPU test cases.

Changes

Cohort / File(s) Summary
Test Skip Message Updates
tests/integration/defs/accuracy/test_llm_api_pytorch.py
Simplified pytest.skip messages for H20 GPU TRITON MXFP4 MoE backend tests; replaced detailed explanation with "perf issue" while retaining bug reference (nvbugs/5446119) and CUDA 13.3 fix note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description consists only of the template with empty sections and no actual content filled in; Description, Test Coverage, and title are all missing or incomplete. Complete the PR description by: (1) adding a proper title following the format [ticket/issue][type] Summary, (2) filling in the Description section explaining what was changed and why, (3) documenting relevant test coverage in the Test Coverage section.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][doc] update verbose comments' correctly relates to the changeset, which updates pytest.skip messages (verbose comments) in test files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@VALLIS-NERIA

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "comment only change"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #45218 [ skip ] triggered by Bot. Commit: c0b486f Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #45218 [ skip ] completed with state SUCCESS. Commit: c0b486f
Skipping testing for commit c0b486f

Link to invocation

@VALLIS-NERIA
VALLIS-NERIA merged commit 0a27cf9 into NVIDIA:main Apr 24, 2026
6 of 7 checks passed
ziyixiong-nv pushed a commit to ziyixiong-nv/TensorRT-LLM that referenced this pull request Apr 24, 2026
Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
longlee0622 pushed a commit to longlee0622/TensorRT-LLM that referenced this pull request Apr 24, 2026
Signed-off-by: xiweny <13230610+VALLIS-NERIA@users.noreply.github.com>
(cherry picked from commit 0a27cf9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants