Skip to content

[https://nvbugs/6114141][test] Remove deprecated disagg trtllm_sampler test#14335

Merged
Shixiaowei02 merged 1 commit into
NVIDIA:mainfrom
Shixiaowei02:user/xiaoweis/rm-tllm-sampler-disagg
May 21, 2026
Merged

[https://nvbugs/6114141][test] Remove deprecated disagg trtllm_sampler test#14335
Shixiaowei02 merged 1 commit into
NVIDIA:mainfrom
Shixiaowei02:user/xiaoweis/rm-tllm-sampler-disagg

Conversation

@Shixiaowei02

@Shixiaowei02 Shixiaowei02 commented May 20, 2026

Copy link
Copy Markdown
Collaborator

TRTLLMSampler is deprecated and will be removed in release 1.4. The GB300 CI test test_disaggregated_trtllm_sampler has been waived for NVBUG 6114141 (NIXL/UCX TCP send failure during KV cache transfer, which leaves the GEN side hung waiting for a sync that the CTX side never sends). Since the sampler under test is going away, drop the test, its config, the QA list references, and the waiver entry.

Summary by CodeRabbit

  • Tests
    • Removed TRT-LLM sampler disaggregated test scenario and related test configuration from the integration test suite, including removal from test lists and waivers.

Review Change Stack

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…r test

TRTLLMSampler is deprecated and will be removed in release 1.4. The
GB300 CI test `test_disaggregated_trtllm_sampler` has been waived for
NVBUG 6114141 (NIXL/UCX TCP send failure during KV cache transfer,
which leaves the GEN side hung waiting for a sync that the CTX side
never sends). Since the sampler under test is going away, drop the
test, its config, the QA list references, and the waiver entry.

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
@Shixiaowei02
Shixiaowei02 force-pushed the user/xiaoweis/rm-tllm-sampler-disagg branch from 31846f4 to fb7901c Compare May 20, 2026 05:41
@coderabbitai

coderabbitai Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 27d707db-2940-4780-9e30-61dbfed14c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 8923e38 and fb7901c.

📒 Files selected for processing (6)
  • tests/integration/defs/.test_durations
  • tests/integration/defs/disaggregated/test_configs/disagg_config_trtllm_sampler.yaml
  • tests/integration/defs/disaggregated/test_disaggregated.py
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/integration/test_lists/qa/llm_function_rtx6k.txt
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (5)
  • tests/integration/test_lists/qa/llm_function_rtx6k.txt
  • tests/integration/defs/.test_durations
  • tests/integration/defs/disaggregated/test_configs/disagg_config_trtllm_sampler.yaml
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR removes the trtllm_sampler disaggregated test mode entirely from the integration test suite. The changes include deleting the test function, removing its configuration entry and client selection logic, and updating all test duration records, QA test lists, and waivers to exclude this test scenario.

Changes

trtllm_sampler test mode removal

Layer / File(s) Summary
Test implementation and config cleanup
tests/integration/defs/disaggregated/test_disaggregated.py
Removes the test_disaggregated_trtllm_sampler test function, deletes its configuration entry from get_test_config(), and updates get_client_test_set() to no longer special-case trtllm_sampler test selection.
Test metadata and list cleanup
tests/integration/defs/.test_durations, tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_rtx6k.txt, tests/integration/test_lists/waives.txt
Removes the test duration entry, deletes the test case from QA test lists, and removes the waiver entry for the removed test scenario.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • reasonsolo
  • ZhanruiSunCh
  • jieli-matrix
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description explains the rationale (deprecated sampler being removed) and what is being removed (test, config, QA references, waiver), but the PR description template sections (Description, Test Coverage, PR Checklist details) are largely not filled out. Fill in the Description and Test Coverage sections to explain the changes and their impact more thoroughly, and complete the PR Checklist checklist items.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly identifies the main change: removing the deprecated disaggregated trtllm_sampler test, with the NVBugs ticket and appropriate [test] type indicator.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@Shixiaowei02

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49348 [ run ] triggered by Bot. Commit: fb7901c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #49348 [ run ] completed with state SUCCESS. Commit: fb7901c
/LLM/main/L0_MergeRequest_PR pipeline #39004 completed with status: 'SUCCESS'

CI Report

Link to invocation

@Shixiaowei02
Shixiaowei02 merged commit b3fcf08 into NVIDIA:main May 21, 2026
12 of 13 checks passed
@Shixiaowei02
Shixiaowei02 deleted the user/xiaoweis/rm-tllm-sampler-disagg branch May 21, 2026 01:58
xxi-nv pushed a commit to xxi-nv/TensorRT-LLM that referenced this pull request May 22, 2026
…r test (NVIDIA#14335)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
…r test (NVIDIA#14335)

Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants