[https://nvbugs/6114141][test] Remove deprecated disagg trtllm_sampler test#14335
Conversation
…r test TRTLLMSampler is deprecated and will be removed in release 1.4. The GB300 CI test `test_disaggregated_trtllm_sampler` has been waived for NVBUG 6114141 (NIXL/UCX TCP send failure during KV cache transfer, which leaves the GEN side hung waiting for a sync that the CTX side never sends). Since the sampler under test is going away, drop the test, its config, the QA list references, and the waiver entry. Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
31846f4 to
fb7901c
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughThis PR removes the Changestrtllm_sampler test mode removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot run --disable-fail-fast |
|
PR_Github #49348 [ run ] triggered by Bot. Commit: |
|
PR_Github #49348 [ run ] completed with state |
…r test (NVIDIA#14335) Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
…r test (NVIDIA#14335) Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
TRTLLMSampler is deprecated and will be removed in release 1.4. The GB300 CI test
test_disaggregated_trtllm_samplerhas been waived for NVBUG 6114141 (NIXL/UCX TCP send failure during KV cache transfer, which leaves the GEN side hung waiting for a sync that the CTX side never sends). Since the sampler under test is going away, drop the test, its config, the QA list references, and the waiver entry.Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.