Skip to content

[https://nvbugs/6250866][fix] Fix deep ep partial warp sync for gptoss shapes#14977

Merged
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:user/dongfengy/deepep-fix-v2
Jun 6, 2026
Merged

[https://nvbugs/6250866][fix] Fix deep ep partial warp sync for gptoss shapes#14977
dongfengy merged 1 commit into
NVIDIA:mainfrom
dongfengy:user/dongfengy/deepep-fix-v2

Conversation

@dongfengy

@dongfengy dongfengy commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

NOTE: This ensure partial warp sync is fine.

[NVBUG-6250866][bugfix] wire DeepEP patch into FetchContent

Summary by CodeRabbit

  • Bug Fixes
    • Applied a fix to GPU kernel synchronization to improve stability and correctness of deep learning computations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@dongfengy
dongfengy marked this pull request as ready for review June 4, 2026 22:43
@dongfengy
dongfengy requested a review from a team as a code owner June 4, 2026 22:43
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The PR registers a CUDA kernel synchronization fix for the deep_ep third-party dependency. The fetch configuration now references a new patch file that replaces bare warp synchronization calls with active-mask-aware variants to handle the case where the final tile contains fewer lanes than a full warp.

Changes

CUDA Synchronization Fix for deep_ep

Layer / File(s) Summary
Patch configuration and intranode synchronization fix
3rdparty/fetch_content.json, 3rdparty/patches/deep_ep_intranode_combine_fix.patch
The deep_ep_download entry in fetch_content.json is updated to register patches/deep_ep_intranode_combine_fix.patch for automatic application. The patch replaces __syncwarp() with __syncwarp(__activemask()) at TMA wait, fence, and final synchronization points in intranode.cu, ensuring only active warp lanes participate when the final tile has a subset of lanes.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description lacks essential details required by the template, with only a brief note and title but missing implementation explanation and test coverage information. Fill in the Description section explaining the issue being fixed and the solution approach, and detail relevant tests that validate the warp synchronization fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: fixing partial warp synchronization in Deep EP for GPT-OSS shapes, which is the core issue addressed by the patch to intranode.cu and the FetchContent configuration update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@dongfengy dongfengy changed the title [NVBUG-6250866][bugfix] Fix deep ep partial warp sync for gptoss shapes [https://nvbugs/6250866][bugfix] Fix deep ep partial warp sync for gptoss shapes Jun 4, 2026
@dongfengy dongfengy changed the title [https://nvbugs/6250866][bugfix] Fix deep ep partial warp sync for gptoss shapes [https://nvbugs/6250866][fix] Fix deep ep partial warp sync for gptoss shapes Jun 4, 2026
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52176 [ run ] triggered by Bot. Commit: ec4d1f3 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52176 [ run ] completed with state SUCCESS. Commit: ec4d1f3
/LLM/main/L0_MergeRequest_PR pipeline #41496 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@dongfengy
dongfengy force-pushed the user/dongfengy/deepep-fix-v2 branch from ec4d1f3 to 1df8987 Compare June 5, 2026 03:24
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52254 [ run ] triggered by Bot. Commit: 1df8987 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52254 [ run ] completed with state FAILURE. Commit: 1df8987
/LLM/main/L0_MergeRequest_PR pipeline #41568 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>

[NVBUG-6250866][bugfix] wire DeepEP patch into FetchContent

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
@dongfengy
dongfengy force-pushed the user/dongfengy/deepep-fix-v2 branch from 1df8987 to 339ef49 Compare June 5, 2026 16:43
@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52384 [ run ] triggered by Bot. Commit: 339ef49 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52384 [ run ] completed with state SUCCESS. Commit: 339ef49
/LLM/main/L0_MergeRequest_PR pipeline #41680 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@dongfengy

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52433 [ run ] triggered by Bot. Commit: 339ef49 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #52433 [ run ] completed with state SUCCESS. Commit: 339ef49
/LLM/main/L0_MergeRequest_PR pipeline #41727 completed with status: 'SUCCESS'

CI Report

Link to invocation

@dongfengy
dongfengy merged commit d639c57 into NVIDIA:main Jun 6, 2026
7 checks passed
2ez4bz pushed a commit to 2ez4bz/TensorRT-LLM that referenced this pull request Jun 8, 2026
…s shapes (NVIDIA#14977)

Signed-off-by: Dongfeng Yu <dongfengy@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants