Skip to content

[https://nvbugs/6094068][fix] Fix Qwen3-Next bf16 4gpu test#15206

Merged
JadoTu merged 9 commits into
NVIDIA:mainfrom
JadoTu:bugfix_6094068
Jun 25, 2026
Merged

[https://nvbugs/6094068][fix] Fix Qwen3-Next bf16 4gpu test#15206
JadoTu merged 9 commits into
NVIDIA:mainfrom
JadoTu:bugfix_6094068

Conversation

@JadoTu

@JadoTu JadoTu commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Tests

  • Updated CUDA graph and LLM configuration parameters for test scenarios
  • Adjusted test waiver list to modify skip conditions for specific test cases

Description

  1. Fix the OOM issue via max_batch_size setting.
  2. Unwaive related tests.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: jiant <107457950+JadoTu@users.noreply.github.com>
@JadoTu
JadoTu requested a review from a team as a code owner June 10, 2026 07:21
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e8b180f6-cfdf-491a-acd1-44f86375353a

📥 Commits

Reviewing files that changed from the base of the PR and between 31e730a and 3fe1f2a.

📒 Files selected for processing (2)
  • tests/integration/defs/accuracy/test_llm_api_pytorch.py
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

This PR updates LLM API PyTorch test configurations and adjusts corresponding test waivers. Specifically, it modifies CUDA graph and batch size parameters in test_bf16_4gpu and test_nvfp4, then removes skip waivers for configurations that are no longer expected to fail.

Changes

Test Configuration and Waivers Update

Layer / File(s) Summary
CUDA graph and LLM parameter configuration
tests/integration/defs/accuracy/test_llm_api_pytorch.py
test_bf16_4gpu now configures CUDA graphs with fixed max_batch_size=128 and padding enabled, and sets LLM max_num_tokens=8192 and max_batch_size=128. test_nvfp4 explicitly sets max_batch_size=512 in LLM instantiation.
Test waivers alignment
tests/integration/test_lists/waives.txt
Removed skip waivers for test_bf16_4gpu with tp4ep4_cudagraph_overlap_adp_on and test_nvfp4 with tp4ep4_adp_on-trtllm, while retaining test_nvfp4[tp1-cutlass] skip waiver.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • kaiyux
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the main change: fixing a Qwen3-Next bf16 4gpu test issue as described by the NVBugs ticket reference.
Description check ✅ Passed The description includes required sections (Description and PR Checklist) with relevant details about fixing an OOM issue and unwaiving tests, though Test Coverage section is missing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch bugfix_6094068

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Jian Tu <107457950+JadoTu@users.noreply.github.com>
@JadoTu

JadoTu commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53294 [ run ] triggered by Bot. Commit: 72fb348 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53294 [ run ] completed with state SUCCESS. Commit: 72fb348
/LLM/main/L0_MergeRequest_PR pipeline #42483 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53458 [ run ] triggered by Bot. Commit: 72fb348 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53458 [ run ] completed with state SUCCESS. Commit: 72fb348
/LLM/main/L0_MergeRequest_PR pipeline #42623 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53864 [ run ] triggered by Bot. Commit: 72fb348 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #53864 [ run ] completed with state SUCCESS. Commit: 72fb348
/LLM/main/L0_MergeRequest_PR pipeline #42971 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54011 [ run ] triggered by Bot. Commit: a66ffcd Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54011 [ run ] completed with state SUCCESS. Commit: a66ffcd
/LLM/main/L0_MergeRequest_PR pipeline #43095 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54256 [ run ] triggered by Bot. Commit: 2c08dad Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54256 [ run ] completed with state SUCCESS. Commit: 2c08dad
/LLM/main/L0_MergeRequest_PR pipeline #43331 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Jian Tu <107457950+JadoTu@users.noreply.github.com>
@JadoTu

JadoTu commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@JadoTu
JadoTu enabled auto-merge (squash) June 16, 2026 05:18
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54472 [ run ] triggered by Bot. Commit: 40dd603 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54472 [ run ] completed with state SUCCESS. Commit: 40dd603
/LLM/main/L0_MergeRequest_PR pipeline #43538 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54770 [ run ] triggered by Bot. Commit: ed6a78c Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54770 [ run ] completed with state SUCCESS. Commit: ed6a78c
/LLM/main/L0_MergeRequest_PR pipeline #43789 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@JadoTu

JadoTu commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55016 [ run ] triggered by Bot. Commit: d0f775b Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55016 [ run ] completed with state SUCCESS. Commit: d0f775b
/LLM/main/L0_MergeRequest_PR pipeline #44008 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@JadoTu

JadoTu commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55391 [ run ] triggered by Bot. Commit: 93de504 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55391 [ run ] completed with state SUCCESS. Commit: 93de504
/LLM/main/L0_MergeRequest_PR pipeline #44338 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Signed-off-by: Jian Tu <107457950+JadoTu@users.noreply.github.com>
@JadoTu

JadoTu commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55704 [ run ] triggered by Bot. Commit: 7d0ef42 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #55704 [ run ] completed with state SUCCESS. Commit: 7d0ef42
/LLM/main/L0_MergeRequest_PR pipeline #44608 completed with status: 'SUCCESS'

CI Report

Link to invocation

@JadoTu
JadoTu merged commit 4c4c74a into NVIDIA:main Jun 25, 2026
7 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…5206)

Signed-off-by: jiant <107457950+JadoTu@users.noreply.github.com>
Signed-off-by: Jian Tu <107457950+JadoTu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants