[None][test] waive hang issues#15576
Conversation
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughAdds SKIP waivers to the integration test waiver list for parametrized cases across ChangesIntegration test skip waivers and duration baselines
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
7-10: 🩺 Stability & Availability | 🔵 TrivialCoverage status: insufficient; needs follow-up outside this PR.
This PR adds/expands waivers in
tests/integration/test_lists/waives.txt, so effective integration coverage is reduced for:
accuracy/test_llm_api_autodeploy.pyaccuracy/test_llm_api_pytorch.pyaccuracy/test_llm_api_pytorch_multimodal.pyPlease track unwaive criteria + owner/ETA in a follow-up issue/PR so these paths are re-enabled once fixes land.
As per path instructions, “Act as a QA engineer reviewing test changes and coverage… suggest concrete list file names and whether coverage is sufficient, insufficient, or needs follow-up outside the PR.”
Also applies to: 53-53, 72-76, 161-161, 182-182
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` around lines 7 - 10, Coverage is insufficient because `tests/integration/test_lists/waives.txt` is adding or expanding skips that reduce effective integration coverage for the listed LLM accuracy tests. Update the waiver change to include a clear follow-up plan outside this PR: document unwaive criteria plus an owner and ETA for re-enabling the affected paths (`accuracy/test_llm_api_autodeploy.py`, `accuracy/test_llm_api_pytorch.py`, `accuracy/test_llm_api_pytorch_multimodal.py`). Keep the waiver entries in `waives.txt`, but ensure the PR or a linked follow-up issue tracks when these `SKIP` items will be removed.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 72: The waiver entry for TestQwen3_8B::test_eagle3 is missing the actual
NVBUG ticket number in its skip reason. Update the reason string to use the
short nvbug URL format with the full ID (for example, https://nvbugs/1234567) so
the waiver remains actionable and consistent with the rest of the list.
---
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 7-10: Coverage is insufficient because
`tests/integration/test_lists/waives.txt` is adding or expanding skips that
reduce effective integration coverage for the listed LLM accuracy tests. Update
the waiver change to include a clear follow-up plan outside this PR: document
unwaive criteria plus an owner and ETA for re-enabling the affected paths
(`accuracy/test_llm_api_autodeploy.py`, `accuracy/test_llm_api_pytorch.py`,
`accuracy/test_llm_api_pytorch_multimodal.py`). Keep the waiver entries in
`waives.txt`, but ensure the PR or a linked follow-up issue tracks when these
`SKIP` items will be removed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: fcdb6a09-c218-43bb-be7b-5c0a3a249137
📒 Files selected for processing (2)
tests/integration/defs/.test_durationstests/integration/test_lists/waives.txt
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot skip --comment "only waive test" |
|
PR_Github #127 [ skip ] triggered by Bot. Commit: |
|
PR_Github #55430 [ skip ] triggered by Bot. Commit: |
|
PR_Github #127 [ skip ] completed with state |
|
PR_Github #55430 [ skip ] completed with state |
|
/bot skip --comment "only waive test" |
|
/bot skip --comment "only waive test" |
|
/bot reuse-pipeline |
|
PR_Github #55443 [ skip ] triggered by Bot. Commit: |
|
PR_Github #55444 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #55443 [ skip ] completed with state |
|
PR_Github #55444 [ reuse-pipeline ] completed with state |
|
/bot skip --comment "only waive test" |
|
PR_Github #55451 [ skip ] triggered by Bot. Commit: |
|
PR_Github #55451 [ skip ] completed with state |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
3 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.