Skip to content

Remove X-XSS-Protection Response Header#378

Merged
ThunderSon merged 8 commits into
masterfrom
remove-X-XSS-Protection-Response-Header
May 4, 2020
Merged

Remove X-XSS-Protection Response Header#378
ThunderSon merged 8 commits into
masterfrom
remove-X-XSS-Protection-Response-Header

Conversation

@mackowski

@mackowski mackowski commented Mar 30, 2020

Copy link
Copy Markdown
Collaborator
  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as TEXT
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

This PR covers issue #376

@mackowski mackowski self-assigned this Mar 30, 2020
@ThunderSon

Copy link
Copy Markdown
Contributor

Yeah that works. I kept on the back burner to see if we should replace it with a small note. Didn't have proper time to think about it. What do you think?

@rbsec

rbsec commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

This header is recommended in a few places, so if we're removing it here we need to remove it everywhere:

  • DotNet Security
  • NodeJS Security
  • Ruby on Rails

Given that we've going against many other people's recommendations here, I think we do still need to include it somewhere in the CS to make it clear that it's an intentional choice not to recommend it, rather than just an omission. The obvious place would be in the CSP section, something along the lines of:

Note that the X-XSS-Protection header has been deprecated by modern browsers and it's use can introduce additional security issues. As such, it is no longer recommended.

And also provide some (reputable) sources where people can go and read more information about it.

@jmanico

jmanico commented Mar 31, 2020 via email

Copy link
Copy Markdown
Member

@mackowski

Copy link
Copy Markdown
Collaborator Author

What about adding new h1 X-XSS-Protection header with content that @rbsec proposed - that way it will be easy to link to it from other places and will be easy to spot.

@jmanico

jmanico commented Mar 31, 2020 via email

Copy link
Copy Markdown
Member

@ThunderSon

Copy link
Copy Markdown
Contributor

I made an update on the 3 mentioned CSs, and on the official one for XSS. Let me know what you think

Comment thread cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.md Outdated
Comment thread cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.md
Comment thread cheatsheets/Nodejs_security_cheat_sheet.md Outdated
@jmanico

jmanico commented Apr 9, 2020 via email

Copy link
Copy Markdown
Member

@ThunderSon
ThunderSon requested a review from rbsec May 4, 2020 09:09
@mackowski

Copy link
Copy Markdown
Collaborator Author

@ThunderSon last update looks good. @rbsec can you review it?

@rbsec rbsec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants