Squiz/MemberVarScope: update for properties with asymmetric visibility#1122
Merged
jrfnl merged 1 commit intoJun 9, 2025
Merged
Conversation
Base automatically changed from
php-8.4/feature/file-methods-support-asym-visibility
to
master
June 9, 2025 01:45
jrfnl
marked this pull request as ready for review
June 9, 2025 01:55
Do still flag when the "get" (read) scope is not specified, but do so with a different error code to allow for rulesets to ignore that error. Includes tests.
jrfnl
force-pushed
the
php-8.4/feature/squiz-membervarscope-support-asym-visibility
branch
from
June 9, 2025 02:37
4c2f7ba to
622ac74
Compare
Member
Author
|
Rebased without changes to get a proper build. |
jrfnl
deleted the
php-8.4/feature/squiz-membervarscope-support-asym-visibility
branch
June 9, 2025 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do still flag when the "get" (read) scope is not specified, but do so with a different error code to allow for rulesets to ignore that error.
Includes tests.
Suggested changelog entry
Related issues/external references
Follow up on #851
Follow up on #1116
Related to #734