Ruleset: hard deprecate support for standards called "Internal"#893
Merged
jrfnl merged 1 commit intoApr 14, 2025
Merged
Conversation
rodrigoprimo
approved these changes
Mar 21, 2025
rodrigoprimo
left a comment
rodrigoprimo
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. I left a comment with a small suggestion.
Support for standards called `Internal` was soft deprecated in PHPCS 3.12.0 This PR adds a new Ruleset deprecation notice for when such a standard would be requested from a ruleset. Support for sniffs not following the naming conventions will be removed in PHPCS 4.0. Includes test. Related to 799
jrfnl
force-pushed
the
feature/799-ruleset-remove-support-for-standard-internal
branch
from
April 14, 2025 08:48
fb5eaeb to
3cc4afb
Compare
Member
Author
|
Rebased without changes before merging. |
jrfnl
deleted the
feature/799-ruleset-remove-support-for-standard-internal
branch
April 14, 2025 09:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for standards called
Internalwas soft deprecated in PHPCS 3.12.0This PR adds a new Ruleset deprecation notice for when such a standard would be requested from a ruleset.
Support for sniffs not following the naming conventions will be removed in PHPCS 4.0.
Includes test.
Suggested changelog entry
Added deprecation notices (hard deprecation) for:
Internal, which will no longer be supported in PHPCS 4.0.Related issues/external references
Related to #799