rm man handling#152
Merged
Merged
Conversation
shane-lawrence
approved these changes
May 24, 2024
joshheinrichs-shopify
added a commit
to joshheinrichs-shopify/nixpkgs
that referenced
this pull request
Sep 27, 2024
In 1.5.2, man pages were removed[1], so Ruby isn't required anymore. [1]: Shopify/ejson#152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #88 ,
ejsonwould fork to the man command for documentation.Since we're using
urfave/cli, we get some pretty good documentation in--help: maintaining these man pages separately is extra overhead.Further, the
hpricottransitive dependency we used for compiling the manpages was abandoned by the author 12 years ago: https://github.com/hpricot/hpricot/blob/master/README.md