prefer goreleaser nfpm to fpm#154
Merged
Merged
Conversation
thepwagner
force-pushed
the
nfpm-is-not-fpm
branch
from
May 29, 2024 14:04
bd8716b to
8fc49e7
Compare
cdenyar
approved these changes
May 29, 2024
alexhope61
approved these changes
May 29, 2024
thepwagner
added a commit
that referenced
this pull request
May 29, 2024
In #154 we started uploading `.deb` artifacts. I forgot we only sign `*.tar.gz`, so the deb's lack provenance. I can not abide.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
fpmgem for building .deb packages with thenfpmlibrary embedded within goreleaser.Modify the Makefile to prefer invoking
goreleaserfor all artifacts. Per the.github/workflows/release.yamlworkflow: this Makefile isn't used during the release process, it's inherited cruft.Moving this logic from the
Makefile, which we don't use, togoreleaser, which we do use, means the next tagged release will have a.debattached with provenance.This PR also upgrades the dependencies specified in
dev.yml: ruby and golang to fresher versions.Testing Instructions
make debwill producedist/*.deb.git rev-parseinstead of theVERSIONfile(?), and I don't want to do that.Related