feat: del raise exception#2134
Merged
Merged
Conversation
|
Code Review for PR 2134: This PR changes raise ValueError to ten_env.log_error in on_init of the Soniox ASR extension. Critical issue: the raise ValueError sat inside a try/except Exception block (lines 127-160). That except branch resets the config to defaults and sends a FATAL_ERROR downstream. By replacing the raise with only a log call, the except block never fires, so the extension silently continues with an invalid config (finalize_mode=IGNORE without endpoint detection). Suggested fix: log the error then still raise, so the outer except handles cleanup. Version bump 0.4.4 to 0.4.5 is appropriate. |
zhangjie02agoraio
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.