Skip to content

feat: del raise exception#2134

Merged
wangyoucao577 merged 1 commit into
mainfrom
feature/yuyidi/soniox_0408
Apr 8, 2026
Merged

feat: del raise exception#2134
wangyoucao577 merged 1 commit into
mainfrom
feature/yuyidi/soniox_0408

Conversation

@diyuyi-agora

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown

Code Review for PR 2134: This PR changes raise ValueError to ten_env.log_error in on_init of the Soniox ASR extension. Critical issue: the raise ValueError sat inside a try/except Exception block (lines 127-160). That except branch resets the config to defaults and sends a FATAL_ERROR downstream. By replacing the raise with only a log call, the except block never fires, so the extension silently continues with an invalid config (finalize_mode=IGNORE without endpoint detection). Suggested fix: log the error then still raise, so the outer except handles cleanup. Version bump 0.4.4 to 0.4.5 is appropriate.

@wangyoucao577
wangyoucao577 merged commit 9f78da9 into main Apr 8, 2026
35 checks passed
@wangyoucao577
wangyoucao577 deleted the feature/yuyidi/soniox_0408 branch April 8, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants