Skip to content

Keep timestamps current for URL Metrics in fixture#1913

Merged
mukeshpanchal27 merged 1 commit into
trunkfrom
fix/stale-fixture-url-metrics
Mar 11, 2025
Merged

Keep timestamps current for URL Metrics in fixture#1913
mukeshpanchal27 merged 1 commit into
trunkfrom
fix/stale-fixture-url-metrics

Conversation

@westonruter

Copy link
Copy Markdown
Member

This addresses an oversight from #1903. When I captured the URL Metrics in the fixture, the timestamp values were all newer than 1 week, so they were all considered fresh. However, after a week test_get_lcp_element_when_group_half_stale started to fail because the URL Metrics would never be half stale anymore due to a different ETag: They would be completely stale due to having timestmaps older than the freshness TTL of one week.

@westonruter westonruter added [Type] Bug An existing feature is broken [Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs labels Mar 10, 2025
@westonruter westonruter requested a review from felixarntz as a code owner March 10, 2025 20:46
@github-actions

github-actions Bot commented Mar 10, 2025

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Mar 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.62%. Comparing base (1a7f906) to head (7737662).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk    #1913   +/-   ##
=======================================
  Coverage   69.62%   69.62%           
=======================================
  Files          86       86           
  Lines        6990     6990           
=======================================
  Hits         4867     4867           
  Misses       2123     2123           
Flag Coverage Δ
multisite 69.62% <ø> (ø)
single 39.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Plugin] Optimization Detective Issues for the Optimization Detective plugin skip changelog PRs that should not be mentioned in changelogs [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants