expose Pd's canvas_realizedollar() and modify set_args() for dollar arguments#54
Conversation
|
Looks good to me. You asked for comments from @timothyschoen in #52 and he didn't object, so I'd say that this can go in now. |
|
Ben, maybe you can follow this up with some proper documentation of how set_args() works in doc/graphics.txt? Or, better yet, add a more detailed example than gui-example to pdlua/examples? With some explanations of set_args() in the patch? And add an example for pd.Class:canvas_realizedollar()? |
|
Just tested it with your provided test patch in vanilla, works perfectly AFAICT. So I'll just go ahead and release this as 0.12.17. |
cool, thanks a lot for merging and all the comments in #52 and here! i assume that the principle functionality is as expected then - so even if there might be objections about implementation details at some point, it's hopefully not critical!
sure, i'm on it! will create a PR for that later today. ... and great to see all those updates to purr data btw! |
|
If I had any objections about the implementation, I'd have voiced them here. No, you implemented everything exactly as I would have done it myself.
Great, looking forward to it!
Oh boy, that was a lot of work this time, but I think that I fixed every single bug and usability issue that my students and I came across during the last 6 semesters. Almost 200 commits went into this release, and except for maybe a dozen commits from the GSoC 2024 contributions, I did all those myself since the end of June. I'm tired now. :) |
creating this PR here mainly to summarize the result of #52, which escalated a bit. these changes certainly require review, and it's obviously also no problem if this PR is declined or needs further modifications.
the primary goal was:
changes:
\$0-namestring to the pd file isn't possible withset_args()as it also escapes the backslash to\\\$0-name. this is addressed with 48f0053findings that may require further consideration:
"$1"string then, for example)\$01from pd in that case will also result in"$1"on the lua side howeveri've tested these changes in my setup without encountering issues so far. to facilitate testing elsewhere, i'm attaching these files (pdlua object and patch): test_dollar.zip