You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix: Correct synchronization lock and add volatile for tpsControlManager
This PR addresses two thread-safety issues in the double-checked locking pattern for tpsControlManager initialization:
Fixed incorrect synchronization lock object:
Changed from GrpcConnection.class.getClass() to GrpcConnection.class to ensure proper lock scope is properly scoped to the current class, preventing unnecessary global lock contention with other classes using similar locking patterns.
Added volatile modifier to tpsControlManager:
Added the volatile keyword to the tpsControlManager variable to ensure proper visibility of the initialized instance across multiple threads, which is a critical part of the double-checked locking pattern to prevent race conditions in instance initialization.
These changes improve both the correctness and performance of the concurrent initialization logic.
Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct synchronization lock and add volatile for tpsControlManager
This PR addresses two thread-safety issues in the double-checked locking pattern for tpsControlManager initialization:
Fixed incorrect synchronization lock object:
Changed from
GrpcConnection.class.getClass()toGrpcConnection.classto ensure proper lock scope is properly scoped to the current class, preventing unnecessary global lock contention with other classes using similar locking patterns.Added volatile modifier to tpsControlManager:
Added the
volatilekeyword to the tpsControlManager variable to ensure proper visibility of the initialized instance across multiple threads, which is a critical part of the double-checked locking pattern to prevent race conditions in instance initialization.These changes improve both the correctness and performance of the concurrent initialization logic.