[ISSUE #14115] Fix console-ui pagination reset to 0 instead of 1 on API error#14121
Merged
KomachiSion merged 1 commit intoJan 20, 2026
Conversation
…ibaba#14115) When API requests fail (e.g., 403 permission error), the pagination state was incorrectly reset to currentPage: 0. This caused subsequent API calls to use pageNo=0, which is invalid since pagination starts from 1. Fixed in the following components: - ServiceList: service list query error handler - ClusterNodeList: cluster node list query error handler - ConfigurationManagement: config clone/import error handlers Signed-off-by: cxhello <caixiaohuichn@gmail.com>
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
KomachiSion
approved these changes
Jan 20, 2026
shiyiyue1102
pushed a commit
to shiyiyue1102/nacos
that referenced
this pull request
Jan 20, 2026
…ibaba#14115) (alibaba#14121) When API requests fail (e.g., 403 permission error), the pagination state was incorrectly reset to currentPage: 0. This caused subsequent API calls to use pageNo=0, which is invalid since pagination starts from 1. Fixed in the following components: - ServiceList: service list query error handler - ClusterNodeList: cluster node list query error handler - ConfigurationManagement: config clone/import error handlers Signed-off-by: cxhello <caixiaohuichn@gmail.com>
KomachiSion
pushed a commit
that referenced
this pull request
Feb 4, 2026
…4115) (#14121) When API requests fail (e.g., 403 permission error), the pagination state was incorrectly reset to currentPage: 0. This caused subsequent API calls to use pageNo=0, which is invalid since pagination starts from 1. Fixed in the following components: - ServiceList: service list query error handler - ClusterNodeList: cluster node list query error handler - ConfigurationManagement: config clone/import error handlers Signed-off-by: cxhello <caixiaohuichn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14115
What is the purpose of the change
Fix the pagination bug in console-ui where
currentPagewas incorrectly reset to 0 instead of 1 when API requests fail. This caused subsequent API calls to usepageNo=0, which is invalid since pagination starts from 1.Brief changelog
currentPage: 0→currentPage: 1in error handlers:ServiceList.js: service list query error handlerClusterNodeList.js: cluster node list query error handlerConfigurationManagement.js: config clone/import error handlers (2 places)Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.