[ISSUE #14479] Fix typo and improve code quality in health check processors#14480
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
|
Please Fix the CI problem. @DocJlm |
- Fix typo: rename 'deepth' to 'depth' in HttpHealthCheckProcessor and MysqlHealthCheckProcessor loop variables - Fix incorrect Javadoc: MysqlHealthCheckProcessor was documented as "TCP health check processor" instead of "MySQL health check processor" - Refactor MysqlCheckTask to use try-with-resources for Statement and ResultSet, ensuring proper resource cleanup and reducing boilerplate code in the finally block
e25444c to
ba50980
Compare
|
Fixed. Removed the unused import com.alibaba.nacos.naming.misc.Loggers that was left over after the try-with-resources refactoring. @KomachiSion Could you please approve the workflows and re-review? Thanks |
|
@DocJlm Thanks |
|
|
What is the purpose of the change
Fix typo, incorrect Javadoc, and improve resource management in health check processors under the naming module. Resolves #14479.
deepthtodepthinHttpHealthCheckProcessorandMysqlHealthCheckProcessorloop variablesMysqlHealthCheckProcessorwas documented as "TCP health check processor" instead of "MySQL health check processor"MysqlCheckTaskto use try-with-resources forStatementandResultSet, ensuring proper resource cleanup and reducing boilerplate code in the finally blockBrief changelog
HttpHealthCheckProcessor.java: Fix variable name typo (deepth→depth)MysqlHealthCheckProcessor.java: Fix Javadoc, fix typo, refactor to try-with-resourcesVerifying this change
This is a code quality improvement. The logic remains the same, only resource management pattern and naming are improved. Existing tests cover the functionality.
[ISSUE #14479] Fix typo and improve code quality in health check processors.