[issue #14484]Add 'type' and 'md5' fields to findConfigInfoLike4PageFetchRows for plugin development#14485
Merged
KomachiSion merged 1 commit intoFeb 25, 2026
Conversation
|
Thanks for your this PR. 🙏 感谢您提交的PR。 🙏 |
KomachiSion
requested changes
Feb 25, 2026
|
|
||
| public interface ConfigInfoMapper extends Mapper { | ||
|
|
Collaborator
There was a problem hiding this comment.
Please don't change indent
Contributor
Author
There was a problem hiding this comment.
Thanks for the review.
I have reverted the indentation changes and kept only the functional modifications.
Please kindly review again.
- Add 'type' and 'md5' to findConfigInfoLike4PageFetchRows in ConfigInfoMapper. - Add 'type' and 'md5' to findConfigInfoLike4PageFetchRows in ConfigTagsRelationMapper. Close #14484
java-acc
force-pushed
the
issue-14484-docs-datasource-plugin
branch
from
February 25, 2026 09:16
1f748f2 to
0c16ba8
Compare
KomachiSion
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #14484
What is the purpose of the change
The root cause of the UI display issue is that the findConfigInfoLike4PageFetchRows method in both ConfigInfoMapper and ConfigTagsRelationMapper lacked the type and md5 fields in their documentation.
By adding these missing fields, this PR ensures that developers of other data source plugins (e.g., for different databases) can correctly implement and handle these fields, maintaining data consistency and proper UI echoing.
Brief changelog
ConfigInfoMapper: Added type and md5 fields to the documentation/annotations of the findConfigInfoLike4PageFetchRows method.
ConfigTagsRelationMapper: Added type and md5 fields to the documentation/annotations of the findConfigInfoLike4PageFetchRows method.
Ensured that data source plugin developers can reference complete field information to avoid missing configuration types and MD5 checksums in the UI.
I will submit PostgreSQL data source plugin 3.1.1 to the plugin repository later.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.