Skip to content

[issue #14484]Add 'type' and 'md5' fields to findConfigInfoLike4PageFetchRows for plugin development#14485

Merged
KomachiSion merged 1 commit into
alibaba:developfrom
java-acc:issue-14484-docs-datasource-plugin
Feb 25, 2026
Merged

[issue #14484]Add 'type' and 'md5' fields to findConfigInfoLike4PageFetchRows for plugin development#14485
KomachiSion merged 1 commit into
alibaba:developfrom
java-acc:issue-14484-docs-datasource-plugin

Conversation

@java-acc

Copy link
Copy Markdown
Contributor

Close #14484

What is the purpose of the change

The root cause of the UI display issue is that the findConfigInfoLike4PageFetchRows method in both ConfigInfoMapper and ConfigTagsRelationMapper lacked the type and md5 fields in their documentation.

By adding these missing fields, this PR ensures that developers of other data source plugins (e.g., for different databases) can correctly implement and handle these fields, maintaining data consistency and proper UI echoing.

Brief changelog

ConfigInfoMapper: Added type and md5 fields to the documentation/annotations of the findConfigInfoLike4PageFetchRows method.

ConfigTagsRelationMapper: Added type and md5 fields to the documentation/annotations of the findConfigInfoLike4PageFetchRows method.

Ensured that data source plugin developers can reference complete field information to avoid missing configuration types and MD5 checksums in the UI.

I will submit PostgreSQL data source plugin 3.1.1 to the plugin repository later.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant

CLAassistant commented Feb 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。


public interface ConfigInfoMapper extends Mapper {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change indent

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.
I have reverted the indentation changes and kept only the functional modifications.
Please kindly review again.

- Add 'type' and 'md5' to findConfigInfoLike4PageFetchRows in ConfigInfoMapper.
- Add 'type' and 'md5' to findConfigInfoLike4PageFetchRows in ConfigTagsRelationMapper.

Close #14484
@java-acc
java-acc force-pushed the issue-14484-docs-datasource-plugin branch from 1f748f2 to 0c16ba8 Compare February 25, 2026 09:16
@KomachiSion
KomachiSion merged commit da6dc34 into alibaba:develop Feb 25, 2026
1 check passed
@KomachiSion KomachiSion added this to the 3.2.0 milestone Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix missing 'type' and 'md5' fields in findConfigInfoLike4PageFetchRows for plugin development

3 participants