Skip to content

fix(console-ui-next): fix login page loop and header when auth disabled#14853

Merged
KomachiSion merged 2 commits into
alibaba:developfrom
Sunrisea:fix/console-ui-next-auth-disabled
Apr 3, 2026
Merged

fix(console-ui-next): fix login page loop and header when auth disabled#14853
KomachiSion merged 2 commits into
alibaba:developfrom
Sunrisea:fix/console-ui-next-auth-disabled

Conversation

@Sunrisea

@Sunrisea Sunrisea commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix login page loop and header when auth disabled

Brief changelog

  • AuthGuard now bypasses token check when authEnabled=false or loginPageEnabled=false, breaking the redirect loop between AuthGuard and login page
  • Header hides user menu (avatar, change password, logout) when auth is disabled

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check spotbugs:check -DskipTests to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Sunrisea added 2 commits April 3, 2026 17:14
- AuthGuard now bypasses token check when authEnabled=false or
  loginPageEnabled=false, breaking the redirect loop between
  AuthGuard and login page
- Header hides user menu (avatar, change password, logout) when
  auth is disabled

Assisted-by: Kiro
@KomachiSion
KomachiSion merged commit 3ad21fa into alibaba:develop Apr 3, 2026
1 check passed
@KomachiSion KomachiSion added this to the 3.2.1 milestone Apr 3, 2026
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@cxhello

cxhello commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

@CH3CHO FYI this PR also fixes #14926 (reported against v3.2.0, which was released before this fix landed). The reproduction in that issue — setting NACOS_CORE_AUTH_CONSOLE_ENABLED=false with NACOS_CONSOLE_UI_DEFAULT=next — hits exactly the AuthGuardLoginPage redirect loop fixed here. The issue is currently locked (anti-spam), so leaving the note here instead.

@CH3CHO

CH3CHO commented Apr 15, 2026

Copy link
Copy Markdown

@CH3CHO FYI this PR also fixes #14926 (reported against v3.2.0, which was released before this fix landed). The reproduction in that issue — setting NACOS_CORE_AUTH_CONSOLE_ENABLED=false with NACOS_CONSOLE_UI_DEFAULT=next — hits exactly the AuthGuardLoginPage redirect loop fixed here. The issue is currently locked (anti-spam), so leaving the note here instead.

Thanks. It works properly with image nacos/nacos-server:v3.2.1-2026.04.03. I will close that issue later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants